Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: upgrade angular 16 #2050

Merged
merged 7 commits into from
Aug 24, 2023
Merged

BREAKING: upgrade angular 16 #2050

merged 7 commits into from
Aug 24, 2023

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Aug 24, 2023

Description

Updgrading Covalent to support Angular 16

What's included?

  • Upgrade support for angular 16.x.x and angular material 16.x.x
  • Upgrading the typescript version to 5.1.6
  • Upgrading all NX packages to 16x
  • Code editor project now uses jest over Karma!
  • Upgrading material to use the latest version

Test Steps

  • npm run start
  • then open the browser to localhost:4200 and browse around
  • finally verify the web components storybook works along with all of th components

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

Copy link
Collaborator

@mikespudwebb mikespudwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward.

The version numbers in package.json seem off to me though. 🤷‍♂️

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@owilliams320 owilliams320 merged commit 36e2c96 into main Aug 24, 2023
7 checks passed
@owilliams320 owilliams320 deleted the feat/upgrade-ng-16 branch August 24, 2023 17:54
owilliams320 added a commit that referenced this pull request Aug 24, 2023
BREAKING CHANGES: upgrade angular 16 (#2050)
owilliams320 added a commit that referenced this pull request Aug 24, 2023
BREAKING CHANGE: upgrade angular 16 (#2050)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants